Update addok-cluster to v0.10.0 and add graceful shutdown handler#13
Merged
jdesboeufs merged 2 commits intomasterfrom Oct 15, 2025
Merged
Update addok-cluster to v0.10.0 and add graceful shutdown handler#13jdesboeufs merged 2 commits intomasterfrom
jdesboeufs merged 2 commits intomasterfrom
Conversation
Co-authored-by: jdesboeufs <1231232+jdesboeufs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to latest addok-cluster version and add onTerminate handler
Update addok-cluster to v0.10.0 and add graceful shutdown handler
Oct 15, 2025
jdesboeufs
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the
addok-clusterdependency to version 0.10.0 and implements graceful shutdown functionality using the newonTerminatecallback feature.Changes
Updated Dependencies
addok-clusterfrom^0.9.0to^0.10.0Server Improvements
The server now properly handles graceful shutdown when receiving termination signals:
Added
onTerminatehandler:Added signal handlers for SIGTERM and SIGINT:
Shutdown Process Flow
cluster.end()is called to gracefully terminate all addok worker nodesonTerminatecallback is triggered automatically by the clusterTests
Added new test file
test/cluster.jsto verify the graceful termination behavior:end()methodBenefits
Testing
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.